Ignore PermissionError in netrc_info()

[Jonney]

I'm running uWSGI, the user is "nobody", the netrc_file should be '~/.netrc'.
But I don't know why, the location trunes out to be '/root/.netrc', so a PermissionError raised, it's better to ignore this error instead of to raise.

[tomchristie]

Okay. It's not super clear if it'd be better for us to ignore this, or to raise it, to ensure the user is aware of the issue.

You can disable .netrc handling by using trust_env=False, which would be a workaround in the meantime.

I suppose we should probably follow requests' lead here and silently ignore .netrc in cases where it is malformed or causes any kind of IOError... https://github.com/psf/requests/blob/master/requests/utils.py#L209

The build on this pull request is currently failing due to linter errors - make sure to run scripts/lint to apply black and other linting checks.

[florimondmanca]

Thanks! A couple of suggestions from me.

[florimondmanca]

@Jonney Also, were you able to debug this by using the netrc module directly in a REPL? There might be something set that would make ~ resolve to the root user (although that seems unlikely).

[Jonney]

You can disable .netrc handling by using trust_env=False, which would be a workaround in the meantime.

It's ugly to use trust_env=False every time, if so, I want to use Requests instead of httpx

[StephenBrown2]

It's ugly to use trust_env=False every time.

Yes, it is. You can use a Client/AsyncClient instance, where trust_env can be set on the client itself, rather that on the request methods:

client = httpx.Client(trust_env=False)
response = client.get('https://example.org')

async with httpx.AsyncClient(trust_env=False) as client:
    response = await client.get('https://example.org')

if so, I want to use Requests instead of httpx

Also, that suggestion was meant as a workaround, not a permanent solution.

[florimondmanca]

We're almost there! A suggestion to simplify things a bit.

Note that the CI build is failing due to a missing type annotation on raise_errors, but dropping this parameter should make the lint error go away too. :-)

[tomchristie]

👍

Now addressed

[tomchristie]

Thanks so much! Now closed, see #1104