Skip to content

Commit

Permalink
Avoid private imports in test cases. (#3403)
Browse files Browse the repository at this point in the history
  • Loading branch information
tomchristie authored Nov 15, 2024
1 parent 2ea2286 commit b47d94c
Showing 1 changed file with 8 additions and 13 deletions.
21 changes: 8 additions & 13 deletions tests/test_content.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import pytest

import httpx
from httpx._content import encode_json

method = "POST"
url = "https://www.example.com"
Expand Down Expand Up @@ -489,24 +488,20 @@ def test_response_invalid_argument():

def test_ensure_ascii_false_with_french_characters():
data = {"greeting": "Bonjour, ça va ?"}
headers, byte_stream = encode_json(data)
json_output = b"".join(byte_stream).decode("utf-8")

response = httpx.Response(200, json=data)
assert (
"ça va" in json_output
"ça va" in response.text
), "ensure_ascii=False should preserve French accented characters"
assert headers["Content-Type"] == "application/json"
assert response.headers["Content-Type"] == "application/json"


def test_separators_for_compact_json():
data = {"clé": "valeur", "liste": [1, 2, 3]}
headers, byte_stream = encode_json(data)
json_output = b"".join(byte_stream).decode("utf-8")

response = httpx.Response(200, json=data)
assert (
json_output == '{"clé":"valeur","liste":[1,2,3]}'
response.text == '{"clé":"valeur","liste":[1,2,3]}'
), "separators=(',', ':') should produce a compact representation"
assert headers["Content-Type"] == "application/json"
assert response.headers["Content-Type"] == "application/json"


def test_allow_nan_false():
Expand All @@ -516,8 +511,8 @@ def test_allow_nan_false():
with pytest.raises(
ValueError, match="Out of range float values are not JSON compliant"
):
encode_json(data_with_nan)
httpx.Response(200, json=data_with_nan)
with pytest.raises(
ValueError, match="Out of range float values are not JSON compliant"
):
encode_json(data_with_inf)
httpx.Response(200, json=data_with_inf)

0 comments on commit b47d94c

Please sign in to comment.