Add support for denominators to throttle strings #9089
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved denominator string parser so you can for example write
1/30s
for 1 request every 30 seconds instead of being limited to throttling by to the closest time unit. Since the current code just uses a lookup table on the denominator, it's pretty straightforward just to jiggle the indexing to look at the end of the string for the suffix, and see if there is a number in the denominator.I imagine some documentation would also need to be updated. But I figured I would get the ball rolling since it seems a straightforward feature.