Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support atomic requests in multiple database connections #7617

Conversation

aradbar
Copy link

@aradbar aradbar commented Oct 26, 2020

Fixes: #7614

Description

  • Fixed support for atomic transaction views for projects with multiple DB connections
  • set_rollback (used by default exception_handler) didn't rollback non-default connections
  • Added a second connection to the test settings for my tests

@aradbar aradbar marked this pull request as ready for review October 26, 2020 13:22
@aradbar aradbar changed the title Support atomic transaction views in multiple database connections Support atomic requests in multiple database connections Oct 26, 2020
@stale
Copy link

stale bot commented Apr 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 30, 2022
@stale stale bot closed this Jan 17, 2023
@auvipy auvipy removed the stale label Jan 17, 2023
@auvipy auvipy reopened this Jan 17, 2023
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be great if you can fix the merge conflicts

@aradbar aradbar force-pushed the support-atomic-transactions-for-multiple-connections branch from e9046cb to ac3e849 Compare January 17, 2023 18:21
@aradbar
Copy link
Author

aradbar commented Jan 17, 2023

@auvipy looks like this issue was already fixed while this PR was waiting #7739

@auvipy
Copy link
Member

auvipy commented Jan 18, 2023

oh wow! thank for cross checking

@auvipy auvipy closed this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Exception handler doesn't rollback transaction of non-default connection
2 participants