-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth support #709
OAuth support #709
Conversation
…r issues - alias oauth2 as oauth - remove rouge print - remove docstring markups - OAuthAuthentication.authenticate() now returns (user, token) two-tuple on success - don't set request.user because it's already set
oauth_provider can be added to INSTALLED_APPS only if these packages are installed
Conflicts: rest_framework/tests/authentication.py
to avoid naming collision with `oauth2` used for OAuth 1
for a cross python versions compatibility
otherwise log a warning
with a warning for incompatibility with Python 3 and taking @tomchristie advice into account on how to reformulate some sentences
For the awesome OAuth 2 support in #693.
@dulaccc, @swistakm - If you have twitter handles, can you let me know them, so I know who to thank when this gets released? :) |
Ideally the docs could do with a bit more polishing but otherwise I think this is basically good-to-go. |
Note: if either of you have anything else you think needs adding/atering before this hits master, you can make PRs against the oauth branch in the meantime, and they'll be added to this PR. |
@tomchristie my twitter handle is the same as my github one : )
Nothing special is coming to my mind, but I'll sure let you know and PR on the oauth branch otherwise. By the way, it's always a pleasure to give a hand on a great project, and |
It seems really interesting!!! It's a must-have feature. Do you plan to merge it into the master soon ? |
@noirbizarre Yup the plan is for this to make it in soon. One last thing I would ideally like to see before this gets merged is a permission class that works together with these oauth authentication classes. Something along these lines...
@swistakm, @dulaccc, @noirbizarre - Anyone fancy taking that on plus tests and issuing a PR against the oauth branch? ;) |
I've some time today, so I can try to integrate that. |
Done. #721 |
@thedrow ^^ thanks! |
Token scope permission class
@thedrow - I've actually no good excuse at all for being slack regarding history, and particularly wrt. to failing tests you make a really good point. Could def be persuaded to clean up my act. :) |
Support for OAuth 1.0a and OAuth 2