OAuth 1.0a authentication #678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wonderful, wonderful, wonderful. Will review this properly later but looks great. Excellent stuff! |
|
Yay for OAuth support :) Looking forward to this. |
| @@ -9,6 +9,18 @@ | |||
| from rest_framework.authtoken.models import Token | |||
| import base64 | |||
|
|
|||
| from django.core.exceptions import ImproperlyConfigured | |||
| try: | |||
| import oauth2 | |||
There was a problem hiding this comment.
Let's use import oauth2 as oauth
…r issues - alias oauth2 as oauth - remove rouge print - remove docstring markups - OAuthAuthentication.authenticate() now returns (user, token) two-tuple on success - don't set request.user because it's already set
oauth_provider can be added to INSTALLED_APPS only if these packages are installed
| @@ -14,6 +14,8 @@ env: | |||
| install: | |||
| - pip install $DJANGO | |||
| - pip install defusedxml==0.3 | |||
| - pip install oauth2 | |||
| - pip install django-oauth-plus | |||
There was a problem hiding this comment.
Needs to only install these on Python 2.x
|
Superseded by #709 (Which includes this work) Make any further pull requests against the Thanks again for this - looking really good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OAuthAuthentication class as discussed in #8.
It usues
django-oauth-plusandoauth2packages. This backend is optional because strongly depends on external libs. This is a reason I don't add new packages torequirements.txt.Added new tests, Auth class and minimal documentation. I changed travis configs too.
In next days i will provide more detailed documentation but at first I will try to add more structure for existing django-oauth-plus docs.