Add '.basename' and '.reverse_action()' to ViewSet #5648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK. Good: I was going to look at #5605 so breaking it up is a win. |
|
Bit agnostic on this - I'll leave it to you fellas. |
|
For context, supporting #5605 would at least require the router to provide the
|
carltongibson
approved these changes
Dec 4, 2017
7 tasks
pchiquet
pushed a commit
to pchiquet/django-rest-framework
that referenced
this pull request
Nov 17, 2020
* Router sets 'basename' on ViewSet * Add 'ViewSet.reverse_action()' method * Test router setting initkwargs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just breaking out a portion of #5605.
Description
ViewSets cannot effectively reverse their action URLs, as they aren't aware of thebasenamethey were registered to the router with. This value can be hardcoded in the view class, however this is problematic when theViewSetis registered with a differentbasename.basenamewith the viewset'sinitkwargs..reverse_action()convenience method to viewsets.