Fix #3844, refine validator for fields with <source=> kwargs #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When serializers has fields with something like `source=user.email`, the uniqueness validator should check `email` field instead of `user`, cause `user` is a model object.
|
Thanks for all the work @xiaohanyu ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix a bug in
UniqueValidatorwhen applied to related model fields. As discussed in #3844 , I first made a proposal, with a demo code and no test, and it got rejected. Two days ago, somebody reported the same error as I met, so I think I should spent a little more time on this and add a regression testcase for this bug fix.When serializers has fields with something like
source=user.email, theuniqueness validator should check
emailfield instead ofuser, causeuseris a model object.