[change] using safer calling way of "@api_view" in docs/tutorial/5-relationships-and-hyperlinked-apis.md #3971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"@api_view" usage error.
|
I don't really see what it fixes. Both tuple and lists should be valid. |
|
If it was only passed by "GET", list is safer then tuple and also can skip the comma. |
|
ok, so it's not a fix in itself, just a change to make it safer for Python newcomers. |
| @@ -11,7 +11,7 @@ Right now we have endpoints for 'snippets' and 'users', but we don't have a sing | |||
| from rest_framework.reverse import reverse | |||
|
|
|||
|
|
|||
| @api_view(('GET',)) | |||
| @api_view(['GET',]) | |||
There was a problem hiding this comment.
Can you remove the coma here to avoid confusion with tuples ?
remove comma
lynndotconfig
changed the title
|
Yes, for Python newcomers. |
xordoquy
added a commit
that referenced
this pull request
Mar 1, 2016
[change] using safer calling way of "@api_view" in docs/tutorial/5-relationships-and-hyperlinked-apis.md
|
Thanks ! |
This was referenced Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
to fix "@api_view" usage error in "docs/tutorial/5-relationships-and-hyperlinked-apis.md"