Fixed TimeField not handling string times. #3809
Conversation
|
I think with a test case it'll be ready to merge. |
|
@xordoquy here the test, I could not find it when I opened the PR but after more digging I think I found it. |
| @@ -1204,6 +1204,8 @@ def to_representation(self, value): | |||
| ) | |||
|
|
|||
| if output_format.lower() == ISO_8601: | |||
| if (isinstance(value, str)): | |||
There was a problem hiding this comment.
Is it works ok on python 2.* with unicode values? Seems similar to #3819
There was a problem hiding this comment.
Could you update str to six.string_types ? (as per #3819 indeed)
There was a problem hiding this comment.
Sure, I will then update both DateField & TimeField to use six.string_types
There was a problem hiding this comment.
@areski The DateTime was out of this PR scope and now conflict with master. Could you merge it please ?
|
Thanks :) |
|
Thanks for the heads-up :) |
Fixed TimeField not handling empty values
xordoquy
changed the title
|
Thanks for the work ! |
|
Thanks for the guidance! On Mon, Jan 11, 2016 at 12:29 PM, Xavier Ordoquy [email protected]
Kind regards, Arezqui Belaid, [email protected] Tel: +34650784355 |
Similar to #3731 but for TimeField