Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #2761 - ListField truncation on HTTP PATCH #3415

Merged
merged 2 commits into from
Sep 21, 2015
Merged

Fixed #2761 - ListField truncation on HTTP PATCH #3415

merged 2 commits into from
Sep 21, 2015

Conversation

adamsc64
Copy link
Contributor

  • Previously, partial serialization during an update request, such as in the case of HTTP PATCH, would have truncated any old values in ListField data. This is because it had relied on the default value of an empty list. But an empty list has different functionality than the sentinel value of empty. Namely, the semantic meaning of an empty list on an update is to remove all the values. Instead, this PR changes validation internals to use the sentinel value of empty instead of an empty list.
  • Included minor refactor of both ListField and MultipleChoiceField, for the sake of consistent code.
  • Included proof of bug in a unit test at cb42b99.
  • Should resolve Issue PATCH with no data is updating ListField values on ModelSerializer instead of leaving them alone #2761.

@adamsc64
Proof of bug encode#2761
cb42b99 
- When not submitting key for list fields or multiple choice, partial
  serialization should result in empty state (key not there), not an
  empty list.
@adamsc64
Fixed encode#2761 - ListField truncation on HTTP PATCH
9ccfc94 
- Checked ``partial`` state when getting value in appropriate field
  classes; return ``empty`` immediately if key not submitted.
@adamsc64 adamsc64 mentioned this pull request Sep 19, 2015
Closed
@xordoquy xordoquy added the Bug label Sep 21, 2015
@xordoquy xordoquy added this to the 3.2.5 Release milestone Sep 21, 2015
xordoquy added a commit that referenced this pull request Sep 21, 2015
@xordoquy
Merge pull request #3415 from adamsc64/issue_2761
f2c6551 
Fixed #2761 - ListField truncation on HTTP PATCH
@xordoquy xordoquy merged commit f2c6551 into encode:master Sep 21, 2015
@xordoquy
Copy link
Collaborator

Good job ! Thanks for the PR.

@xordoquy xordoquy modified the milestones: 3.2.4 Release, 3.2.5 Release Sep 21, 2015
xordoquy added a commit to linovia/django-rest-framework that referenced this pull request Sep 21, 2015
@xordoquy
Add encode#3415 to the 3.2.4 release
6ee3e29
@pyup-bot pyup-bot mentioned this pull request Oct 22, 2016
Merged
@pyup-bot pyup-bot mentioned this pull request Oct 30, 2016
Merged
@pyup-bot pyup-bot mentioned this pull request Feb 26, 2017
Merged
This was referenced Mar 9, 2017
Closed
Closed
Closed
@pyup-bot pyup-bot mentioned this pull request Jun 7, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Sep 19, 2017
Merged
This was referenced Oct 6, 2017
Closed
Closed
Closed
This was referenced Oct 16, 2017
Closed
Closed
Closed
Closed
@pyup-bot pyup-bot mentioned this pull request Nov 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
3.2.4 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@adamsc64 @xordoquy