Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass allow_empty to ListSerializer's children. #3364

Merged
merged 3 commits into from
Sep 9, 2015

Conversation

xordoquy
Copy link
Collaborator

@xordoquy xordoquy commented Sep 3, 2015

This should fix #3361.
Root cause is allow_empty applies to the ListSerializer but not for its children.

@xordoquy xordoquy added this to the 3.2.4 Release milestone Sep 3, 2015
@xordoquy xordoquy added the Bug label Sep 3, 2015
tomchristie added a commit that referenced this pull request Sep 9, 2015
Don't pass `allow_empty` to `ListSerializer`'s children.
@tomchristie tomchristie merged commit a985fc5 into encode:master Sep 9, 2015
@xordoquy xordoquy deleted the bug/3361 branch September 9, 2015 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow_empty does not work on serializers with many=True.
2 participants