push serialzer metadata into field info for field. #3156
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -143,4 +143,7 @@ def get_field_info(self, field): | |||
| for choice_value, choice_name in field.choices.items() | |||
| ] | |||
|
|
|||
| if issubclass(type(field), serializers.Serializer): | |||
| field_info['nested_object'] = self.get_serializer_info(field) | |||
|
|
|||
There was a problem hiding this comment.
This seems reasonable, but probably needs an associated example and test case.
tomchristie
changed the title
|
(Aside: Moved the issue reference into the description - better for readability and interlinking that way) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if field is a serializer and if it is, dump it's info into 'nested_object' field.
Refs #2915.