Support basic authentication with custom user models that change username field #2952
Conversation
…name field Support basic authentication with custom user models with a username field that is not named 'username'.
Compatibility code for getting user model
Import get_user_model from compat module to be compatible with older django versions (e.g. 1.4).
|
Using the Looks okay, but I might need a little more persuading of the necessity for the change. |
Support User model in Django 1.4 that has not a USERNAME_FIELD attribute.
It works fine with Django's ModelBackend but it may not work with other backends, so better be safer than sorry. Particularly, it does not work with django-python3-ldap. According to Django's documentation, an authentication backend is required to implement authenticate(**credentials), which does not dictate the parameter names. That said, using USERNAME_FIELD instead of a hardcoded 'username' is a safer approach imho. |
| if hasattr(user_model, 'USERNAME_FIELD'): | ||
| username_field = user_model.USERNAME_FIELD | ||
| else: | ||
| username_field = 'username' |
There was a problem hiding this comment.
We could slim this down with username_field = getattr(user_model, 'USERNAME_FIELD', 'username') I think?
There was a problem hiding this comment.
Just addressed that
Fix flake8 error
On Tom's suggestion, improve coding style by using a single-line call to getattr() with a default value instead of a multi-line if/else clause.
Support basic authentication with custom user models that change username field
|
Ace! ✨ |
Support basic authentication with custom user models with a username field that is not named 'username'.