-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosmetic fixes in the API browser HTML. #2187
Conversation
Looks good. Note the test failures - we evidently have some shoddy tests, but need fixing up regardless. Feel free to improve on them while your at it, or not, as you see fit. |
Cool thanks, I'll have a look at the tests. Btw there are some CSS rules that don't play too well with Bootstrap: https://github.com/tomchristie/django-rest-framework/blob/master/rest_framework/static/rest_framework/css/default.css#L43-L45 Are these needed? Also I got some pretty weird issue running the tutorial, ping on IRC when you get a chance ;) |
Not obvious - you'd need to review that yourself. |
@loic , tests are passing here if you want to consider if the tests are still valid. https://github.com/vccabral/django-rest-framework/tree/cosmetic_fixes |
Thanks @vccabral, I've added your commit to the PR. I wanted to take some time to review the other tests as Tom suggested but I've been rather caught up. |
Np. Let me know if I can help @loic. Where are the other failing tests? |
This build is passing so I think it's all good. It was more about reviewing and cleaning up the other tests. |
Fab, thanks @loic! |
Cosmetic fixes in the API browser HTML.
I had a quick go at this, just gathering some feedback, I can split into two PR if needed.