Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError when search_fields is omitted #3323

Closed
Rikuoja opened this issue Aug 24, 2015 · 1 comment
Closed

TypeError when search_fields is omitted #3323

Rikuoja opened this issue Aug 24, 2015 · 1 comment
Labels
Bug
Milestone
3.2.4 Release

Comments

@Rikuoja
Copy link
Contributor

Rikuoja commented Aug 24, 2015

Contrary to documentation, if SearchFilter is added but search_fields accidentally (or on purpose) omitted, DRF Release 3.2.3 presents a TypeError when listing a ViewSet. This behavior was not present in Release 3.2.2.
Rikuoja added a commit to Rikuoja/django-rest-framework that referenced this issue Aug 24, 2015
@Rikuoja
Fix encode#3323
65df9fd
@Rikuoja Rikuoja mentioned this issue Aug 24, 2015
Merged
@tomchristie
Copy link
Member

Gotcha, thanks!

@tomchristie tomchristie added this to the 3.2.4 Release milestone Aug 24, 2015
@pyup-bot pyup-bot mentioned this issue Oct 22, 2016
Merged
@pyup-bot pyup-bot mentioned this issue Oct 30, 2016
Merged
@pyup-bot pyup-bot mentioned this issue Feb 26, 2017
Merged
This was referenced Mar 9, 2017
Closed
Closed
Closed
@pyup-bot pyup-bot mentioned this issue Jun 7, 2017
Closed
@pyup-bot pyup-bot mentioned this issue Sep 19, 2017
Merged
This was referenced Oct 6, 2017
Closed
Closed
Closed
This was referenced Oct 16, 2017
Closed
Closed
Closed
Closed
@pyup-bot pyup-bot mentioned this issue Nov 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
3.2.4 Release
Development

No branches or pull requests
2 participants
@tomchristie @Rikuoja