-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor crypto, attestation into crates #92
Conversation
cc16f1f
to
4d219ba
Compare
4d219ba
to
7b24458
Compare
There's an issue when using Enarx for
So @rvolosatovs's PR #79 is making more sense, except for the missing arg for opening the port for listening. |
6380569
to
6112996
Compare
Blocked on me extending |
0f108dd
to
1ba98f8
Compare
53cbd8f
to
6a14b51
Compare
6a14b51
to
2eaab8e
Compare
Signed-off-by: Richard Zak <[email protected]>
a760214
to
b916207
Compare
Co-authored-by: Roman Volosatovs <[email protected]> Signed-off-by: Richard Zak <[email protected]>
b916207
to
f047314
Compare
The second commit changes the runner to Wasmtime, due to the config issue with Enarx needing Enarx.toml, and there being multiple sub-crates which don't have (don't need) their own Enarx.toml. Enarx can be brought back when @bstrie implements the networking config command line, but I'd like to not wait on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
At present, I moved all the cryptography crates into new
cryptography
crate, which also includes the Steward-specific extensions. Though the issue #76 asked for the attestation code to be separated, it depends on several of the extensions. While at it, I figured I'd try to put all of the external crates into the newcryptography
crate, which re-exports them, so that the versioning management is held at a central spot, since the Rust Crypto crates are versioned separately and break when paired with an incorrect version. (Ex:const-oid
is 0.9, elliptic curves are 0.11,der
is 0.6,x509
is 0.1, etc).Signed-off-by: Richard Zak [email protected]