Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor crypto, attestation into crates #92

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

rjzak
Copy link
Member

@rjzak rjzak commented Oct 20, 2022

At present, I moved all the cryptography crates into new cryptography crate, which also includes the Steward-specific extensions. Though the issue #76 asked for the attestation code to be separated, it depends on several of the extensions. While at it, I figured I'd try to put all of the external crates into the new cryptography crate, which re-exports them, so that the versioning management is held at a central spot, since the Rust Crypto crates are versioned separately and break when paired with an incorrect version. (Ex: const-oid is 0.9, elliptic curves are 0.11, der is 0.6, x509 is 0.1, etc).

Signed-off-by: Richard Zak [email protected]

@rjzak
Copy link
Member Author

rjzak commented Oct 21, 2022

There's an issue when using Enarx for cargo test --target=wasm32-wasi, in that the Enarx.toml is referenced. But for the newly added sub-crates, there's no Enarx.toml present (nor should there be).

  • Cargo config doesn't allow for different run vs. test runner, and
  • setting the runner in a config for a sub-crate merely adds to the command which is run, doesn't replace it. (why would they do that?? how is that useful??)

So @rvolosatovs's PR #79 is making more sense, except for the missing arg for opening the port for listening.

@rjzak rjzak force-pushed the crates_refactor branch 3 times, most recently from 6380569 to 6112996 Compare October 26, 2022 15:31
@bstrie
Copy link
Contributor

bstrie commented Oct 27, 2022

Blocked on me extending enarx run allow specifying config parameters on the CLI.

@rjzak rjzak marked this pull request as draft November 2, 2022 15:43
@rjzak rjzak force-pushed the crates_refactor branch 4 times, most recently from 53cbd8f to 6a14b51 Compare November 3, 2022 16:34
@rjzak rjzak marked this pull request as ready for review November 3, 2022 16:35
@rjzak rjzak force-pushed the crates_refactor branch 6 times, most recently from a760214 to b916207 Compare November 3, 2022 17:45
Co-authored-by: Roman Volosatovs <[email protected]>
Signed-off-by: Richard Zak <[email protected]>
@rjzak
Copy link
Member Author

rjzak commented Nov 3, 2022

The second commit changes the runner to Wasmtime, due to the config issue with Enarx needing Enarx.toml, and there being multiple sub-crates which don't have (don't need) their own Enarx.toml. Enarx can be brought back when @bstrie implements the networking config command line, but I'd like to not wait on that.

@rjzak rjzak requested a review from puiterwijk November 4, 2022 16:07
Copy link
Contributor

@puiterwijk puiterwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@npmccallum npmccallum enabled auto-merge (rebase) November 7, 2022 16:38
@npmccallum npmccallum merged commit 5fb350a into enarx:main Nov 7, 2022
@rjzak rjzak deleted the crates_refactor branch November 7, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants