Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check CRLs during attestation #171

Merged
merged 1 commit into from
Feb 1, 2023
Merged

feat: check CRLs during attestation #171

merged 1 commit into from
Feb 1, 2023

Conversation

rjzak
Copy link
Member

@rjzak rjzak commented Jan 13, 2023 •
edited
Loading

Follow-up to #159
Closes: #112

  • Make sure CRL checking works for both Intel (works via CRL-by-Issuer) & AMD.
  • Identify CRL from the pair only by URL.
  • Handle both cases:
    • CRL per CA cert
    • CRL from root CA cert only
  • Logger message for expired CRL

@rjzak rjzak added the attestation Issues related to attestation label Jan 13, 2023
@rjzak rjzak force-pushed the crl_checking branch 3 times, most recently from ad6c3cf to f81a832 Compare January 16, 2023 18:55
@rjzak rjzak marked this pull request as ready for review January 16, 2023 18:55
@rjzak rjzak requested review from a team and bstrie as code owners January 16, 2023 18:55
@rjzak rjzak requested a review from puiterwijk January 16, 2023 18:56
@rjzak rjzak force-pushed the crl_checking branch 2 times, most recently from 58d4045 to b8a3102 Compare January 26, 2023 23:37
@rjzak rjzak requested a review from puiterwijk January 26, 2023 23:44
@rjzak rjzak force-pushed the crl_checking branch 4 times, most recently from 1f256bf to 098ed25 Compare January 31, 2023 20:24
@rjzak rjzak merged commit 2159f19 into enarx:main Feb 1, 2023
@rjzak rjzak deleted the crl_checking branch February 1, 2023 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puiterwijk puiterwijk puiterwijk approved these changes

@bstrie bstrie Awaiting requested review from bstrie

@npmccallum npmccallum Awaiting requested review from npmccallum

@rvolosatovs rvolosatovs Awaiting requested review from rvolosatovs

Assignees
No one assigned
Labels
attestation Issues related to attestation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing SGX attestation steps
2 participants
@rjzak @puiterwijk