Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to heatsource, api, console #870

Merged
merged 28 commits into from
Jan 5, 2023
Merged

Changes to heatsource, api, console #870

merged 28 commits into from
Jan 5, 2023

Conversation

MichaelDvP
Copy link
Contributor

@proddy
Copy link
Contributor

proddy commented Jan 2, 2023

I reviewed the code and tested it (the best I could). looks good. There is a change I need to make in the standalone arduino string library to support api_data but it's minor and I can do it after you've merged this

@MichScha MichScha mentioned this pull request Jan 5, 2023
@MichaelDvP
Copy link
Contributor Author

I've merged the latest dev, solving some merge conflicts and include the latest user inputs.
Also added a translation for "Sensors" in Dashboard device list.
I think we can merge now.

@proddy
Copy link
Contributor

proddy commented Jan 5, 2023

ok!

@MichaelDvP MichaelDvP merged commit 8b2466d into emsesp:dev Jan 5, 2023
proddy added a commit that referenced this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants