Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#828 dump all out entities (standalone only) #851

Merged
merged 6 commits into from
Dec 28, 2022
Merged

#828 dump all out entities (standalone only) #851

merged 6 commits into from
Dec 28, 2022

Conversation

proddy
Copy link
Contributor

@proddy proddy commented Dec 27, 2022

No description provided.

@proddy proddy requested a review from MichaelDvP December 27, 2022 19:29
MichaelDvP
MichaelDvP approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@MichaelDvP MichaelDvP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit shocked: 110 files changed!
But the main change with dump is much smaller.
Looks all ok, maybe also enclose the header of dump_all_values also in a #ifdef section.

@proddy proddy merged commit c4c3419 into emsesp:dev Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDvP MichaelDvP MichaelDvP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proddy @MichaelDvP