Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix standalone #2224

Merged
merged 3 commits into from
Nov 19, 2024
Merged

fix standalone #2224

merged 3 commits into from
Nov 19, 2024

Conversation

proddy
Copy link
Contributor

@proddy proddy commented Nov 19, 2024

No description provided.

@proddy proddy merged commit 0b1f87b into emsesp:dev Nov 19, 2024
1 check passed
@mattreim
Copy link
Contributor

Update German translation:

MAKE_TRANSLATION(cyl3BottomTemp, "cyl3bottomtemp", "third cylinder bottom temperature (TS11)", "Speichertemperatur unten (TS11)") 

I think it's not enough for a PR.

@proddy
Copy link
Contributor Author

proddy commented Nov 19, 2024

Everything you do @mattreim deserves a PR !

@mattreim
Copy link
Contributor

mattreim commented Nov 19, 2024

Small question: did you want the underline in the download button? Because the others don't have it.

EMS-Download

@proddy
Copy link
Contributor Author

proddy commented Nov 19, 2024

No, but I couldn't find a way to remove it as it's a URL link, and the default behaviour is to show the underline. I'll look again for a way to remove it.

Another question: What's your opinion on having the Devices' names shown in bold text on the Dashboard and Device WebU pages? Should this be not-bold or in a different colour?

@mattreim
Copy link
Contributor

I always find bold print and colors to stand out well and differentiate well. Color can also be good for the dashboard.

@mattreim
Copy link
Contributor

And I'll say it again, it's getting better and more stable. Great work ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants