fix analog input pullup and counter on gpio 25/26, dac values on web #2201 #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A small note: the installer image is gone.
|
|
thnaks Michael for picking this one up so quickly |
I'll look into that now |
|
And this translation could be used for the new firmware page. EMS-ESP32/interface/src/i18n/en/index.ts Lines 178 to 179 in bf21097 |
|
fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the documentation is still ok.
One of the pin links seems broken and the valid pins only listed for esp32, not for the s3 chip.
S2 have a DAC (S3 not) on pin 23/24, but these pin are gpio 17/18.
Seems to be much work to display S2 dac on web correctly, skipped it as we have no official S2 support.