update Mqtt Client #1273
Merged
update Mqtt Client #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proddy
approved these changes
Aug 31, 2023
| @@ -166,9 +166,9 @@ void WebStatusService::webStatusService(AsyncWebServerRequest * request) { | |||
| if (Mqtt::enabled()) { | |||
| statJson = statsJson.createNestedObject(); | |||
| statJson["id"] = 5; | |||
| statJson["s"] = Mqtt::publish_count(); | |||
| statJson["s"] = Mqtt::publish_count() - Mqtt::publish_fails(); | |||
There was a problem hiding this comment.
statJson["s"] is for success, publish_count() is all messages. Same correction for quality calculation.
|
really great work hunting down the root cause for this freeze/restarts Michael. |
|
And @MichaelDvP I think we need to make a v3.6.1 soon, based on what we have in dev |
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bert has fixed the issues in mqtt. But i leave the default mem level in the library and added a check in mqtt.c. Let's hope that this was the issue from #1264
#1271 is included