web render update - #1116 #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR is getting big so I'm planning to push the changes in a few days, which means different UI and the rename of dallas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lots of minor refactoring to improve performance in the Web. There was a lot of re-rendering when inputting data into a modal dialog box. See #1116.
The big change is making separate react component classes for the dialog modals, preventing excessive rendering of the parent classes. it should improve performance.
Note:
It does break backward compatibility with 3.6.0-dev-9 with Entity Customization as the payload format has changed. The device id and type id are now numbers (not strings). And the JSON and endpoints are called
entitiesto keep with the standard naming convention.