Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Device Name #872

Closed
proddy opened this issue Jan 1, 2023 · 4 comments
Closed

Translate Device Name #872

proddy opened this issue Jan 1, 2023 · 4 comments
Labels
enhancement New feature or request
Milestone
v3.5.0

Comments

@proddy
Copy link
Contributor

proddy commented Jan 1, 2023

Request from Discord to translate the device names (boiler, thermostat etc)

image

It's a change in EMSdevice::device_type_name()
@proddy proddy added the enhancement New feature or request label Jan 1, 2023
@proddy proddy added this to the v3.5.0 milestone Jan 1, 2023
@MichaelDvP
Copy link
Contributor

Think about the lot of usages: mqtt topic, system-info, api device, command device and which should be translated without braking to much. Dashboard/Customizaton and HA friendly name are safe, i think.

@proddy
Copy link
Contributor Author

proddy commented Jan 1, 2023

yes, good point. I did check for all those cases

@mvjt mvjt mentioned this issue Jan 1, 2023
Closed
@proddy
Copy link
Contributor Author

proddy commented Jan 2, 2023

I think I'll only make this change in the WebUI and leave the rest (console, mqtt, API as it is)

proddy added a commit to proddy/EMS-ESP32 that referenced this issue Jan 3, 2023
@proddy
Translate Device Name emsesp#872
5005d06
proddy added a commit to proddy/EMS-ESP32 that referenced this issue Jan 5, 2023
@proddy
updates to Translate Device Name emsesp#872
bab9fd8
proddy added a commit that referenced this issue Jan 5, 2023
@proddy
Merge pull request #885 from proddy/dev
74acf2f 
#872
@proddy
Copy link
Contributor Author

proddy commented Jan 5, 2023

merged into dev

@proddy proddy closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.5.0
Development

No branches or pull requests
2 participants
@proddy @MichaelDvP