Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add units of measurement to translations #752

Closed
tp1de opened this issue Nov 16, 2022 · 1 comment
Closed

Add units of measurement to translations #752

tp1de opened this issue Nov 16, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone
v3.5.0

Comments

@tp1de
Copy link
Contributor

tp1de commented Nov 16, 2022

UOM's for times are not translated: minutes, hours and days.
I think it makes sence to add them as well to translations.
@tp1de tp1de added the enhancement New feature or request label Nov 16, 2022
@MichaelDvP
Copy link
Contributor

According to this comment:

EMS-ESP32/src/locale_common.h

Lines 197 to 198 in c76b4b9

// Unit Of Measurement mapping - maps to DeviceValueUOM_s in emsdevice.cpp
// These don't need translating, it will mess up HA and the API

translation is not compatible with HA.

MichaelDvP added a commit to MichaelDvP/EMS-ESP32 that referenced this issue Nov 19, 2022
@MichaelDvP
add devices alert/Pump emsesp#575, emsesp#720, UOM:translate times? e…
deda1da 
…msesp#752
@MichaelDvP MichaelDvP mentioned this issue Nov 19, 2022
Merged
@proddy proddy added this to the v3.5.0 milestone Nov 19, 2022
@proddy proddy closed this as completed Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.5.0
Development

No branches or pull requests
3 participants
@proddy @tp1de @MichaelDvP