Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

int8 data type (Modbus) #2294

Closed
5 tasks done
GLT-IN opened this issue Dec 18, 2024 · 9 comments
Closed
5 tasks done

int8 data type (Modbus) #2294

GLT-IN opened this issue Dec 18, 2024 · 9 comments

Comments

@GLT-IN
Copy link

GLT-IN commented Dec 18, 2024

DESCRIPTION

Hi,
int8 values are difficult to interpret by second devices, because they are transmitted as int16.
For example minexttemp (register offset: 51) with value "-16" is transmitted as 00 F0, but interpreted as "240".
Is it possible to send int8 as full int16?

REQUESTED INFORMATION

Make sure your have performed every step and checked the applicable boxes before submitting your issue. Thank you!

  • Searched the issue in issues
  • Searched the issue in discussions
  • Searched the issue in the docs
  • Searched the issue in the chat
  • Provide the System information in the area below, taken from http://<IP>/api/system
  Paste System information here....

EXPECTED BEHAVIOUR

A clear and concise description of what you expected to happen.

SCREENSHOTS

image

MichaelDvP added a commit to MichaelDvP/EMS-ESP32 that referenced this issue Dec 18, 2024
@MichaelDvP
Copy link
Contributor

I think it's only one small change, please try https://github.com/MichaelDvP/EMS-ESP32/releases/tag/latest
and check if all is solved.

@GLT-IN
Copy link
Author

GLT-IN commented Dec 19, 2024

Hi,
int8 values are represented correctly now, but the whole system does not run stable.
Devices and entities getting lost and found randomly.

@proddy proddy changed the title int8 data type int8 data type (Modbus) Dec 19, 2024
@GLT-IN
Copy link
Author

GLT-IN commented Dec 19, 2024

every minute the device restarts with v3.7.2-dev.5

@MichaelDvP
Copy link
Contributor

Do the restarts happen only in my version, or also in official v3.7.2-dev.5?
What happen every minute? Commands/reads sent to emsesp?

@GLT-IN
Copy link
Author

GLT-IN commented Dec 19, 2024

it happens in both versions
image

@MichaelDvP
Copy link
Contributor

This is normal after restart. It takes a while to fetch entities from the ems-bus. Trying to read a non existing entity gives this message. After a minute this should stop. But should not lead to a restart.

BTW. i see that recently some registers changes in this commit 9c3044e

@GLT-IN
Copy link
Author

GLT-IN commented Dec 19, 2024

i changed the register addresses and there are no device restarts any more

@GLT-IN
Copy link
Author

GLT-IN commented Dec 19, 2024

Thank you!

@GLT-IN GLT-IN closed this as completed Dec 19, 2024
@MichaelDvP
Copy link
Contributor

i changed the register addresses and there are no device restarts any more

Wrong address or length should only give an errormessage, but no crash.
I'v found a candidate, but not sure if it is fixed now.
Please report if you see this crash again.

proddy added a commit that referenced this issue Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants