Extend "HK1 Mode" #1398

Bingo2023 · 2023-11-07T22:31:34Z

SW: 3.6.3-dev.4
as you can see below, we should extend the hc1 mode:

now: manual, auto
new: manual, auto, stop

Second pic is Buderus App (via MX300).
As I don't know what is the command in detail, I attached a log where I switched via App from "manual" to "Aus".
@MichaelDvP : should we confirm this via custom entity ?

log.txt

Bingo2023 · 2023-11-07T22:35:19Z

one more thing, I think the above setting is supposed the be reflected in HA on below panel:

the mode control in this panel is not linked to hc1/mode ?

MichaelDvP · 2023-11-08T08:40:18Z

Difficult, log shows: gateway(0x48) -W-> thermostat(0x10), RC300Set(0x02B9), data: 00 (offset 21)
but in all logs before this telegram is only offset 0-20. What thermostat (prod-Id, version) is it? What is setting of offset 21 if another mode is set? manual/auto is set in offset 0. Please switch the modes and do a read 10 2B9, hopefully offset 0 and 21 is shown.

Afaik the climate widget is fixed to modes off/heat/auto and can not be changed. HA users may correct me, i'm not using HA.

Bingo2023 · 2023-11-09T19:21:01Z

Hallo Michael,
ich habe eine neue Log gemacht, wo ich die alle 3 Modes per App mehrmals durchgeschalteten habe.
Vielleicht war die erste Log zu kurz. Die Eingaben habe ich alle mit der Buderus App gemacht. Als Thermostat ist ein Buderus RC 220 verbaut (wobei der nur im Keller an der WP ist damit diese läuft, das Haus hat ansonsten KNX).

Was meinst du mit "read 10 2B9"?

log2.txt

Bingo2023 · 2023-11-22T10:47:22Z

I confirm this change, it is working with latest Test release.
Mode change (Aus, Manuell, Auto) is working

t785634 · 2023-11-22T10:51:19Z

But only with the entity select.thermostat_hc1_mode. The Home Assistant thermostat entity (climate.thermostat_hc1) cannot be used to change the mode from Auto to Off.

Bingo2023 · 2023-11-22T12:14:22Z

I checked HA situation:
I marked the Bottoms that I pressed.
Functionality wise it is working perfectly - all the modes are send to the HP.

BUT
as you can see on the pictures, the HA visualization is not very good.

In center is always shows "auto"
the 3 bottoms: two always grey and left always green

Bingo2023 · 2023-11-22T12:17:26Z

have to admit, I used latest Testbuilt from Michael
https://github.com/MichaelDvP/EMS-ESP32/releases/tag/test

t785634 · 2023-11-22T14:37:28Z

Is there a way to make Home Assistant display the correct mode? When I change the mode from Auto to Off, it goes back to Auto after 1 second.
I also use the latest Testbuilt from Michael.

proddy · 2023-12-02T15:50:16Z

@Bingo2023 @t785634 are you still seeing issues with the HA climate control not showing the correct modes? It works for me, but I'm using a different thermostat

MichaelDvP · 2023-12-02T16:20:56Z

We have now two different solutions, in the dev the mode is enhanced to off/manual/auto, but we learned RC300 doesn not have the off-mode. I feat we'll get complains from RC300 users for not working mode. In my test (dev2) i've made a split for RC300 types and BC400 thermostats for thermostat-mode and ww-mode. Don't know if product-id 4 and 253 are the only ones with this mode. Still null feedback if it works.
Should we merge the testbuild to dev2 here to have more testers?

Bingo2023 · 2023-12-02T20:01:41Z

@t785634 I can confirm what you describe.
My pic shows the main HA control, from here the control works, but it is not visualized correct. When I click on panel to enlarge it, the mode control is jumping back to auto after 1sec.

So in general the mode control with 3 values works good (off/manual/auto) but the HA implementation needs to be fixed. I'm new to HA so I don't know if EMS-ESP32 or HA...

t785634 · 2023-12-04T12:56:25Z

@proddy yes, the problem still exists

proddy · 2023-12-04T20:53:31Z

@proddy yes, the problem still exists

can you use MQTT Explorer or something similar and dig out the MQTT Discovery topic and payload for the climate? It'll be something like homeassistant/climate/ems-esp/thermostat_hc1/config

I need to see the mode_stat_tpl in the JSON as that is probably where the problem lies.

t785634 · 2023-12-04T21:40:08Z

@proddy yes, the problem still exists

can you use MQTT Explorer or something similar and dig out the MQTT Discovery topic and payload for the climate? It'll be something like homeassistant/climate/ems-esp/thermostat_hc1/config

I need to see the mode_stat_tpl in the JSON as that is probably where the problem lies.
/

{
  "~": "ems-esp",
  "uniq_id": "thermostat_hc1",
  "obj_id": "thermostat_hc1",
  "name": "Hc1",
  "mode_stat_t": "~/thermostat_data",
  "mode_stat_tpl": "{%if value_json.hc1 is undefined or value_json.hc1.mode is undefined%}off{%elif value_json.hc1.mode=='manual'%}heat{%elif value_json.hc1.mode=='day'%}heat{%elif value_json.hc1.mode=='night'%}off{%elif value_json.hc1.mode=='off'%}off{%else%}auto{%endif%}",
  "temp_cmd_t": "~/thermostat/hc1/seltemp",
  "temp_stat_t": "~/thermostat_data",
  "temp_stat_tpl": "{{value_json.hc1.seltemp if value_json.hc1 is defined and value_json.hc1.seltemp is defined else 0}}",
  "curr_temp_t": "~/thermostat_data",
  "curr_temp_tpl": "{{value_json.hc1.currtemp if value_json.hc1 is defined and value_json.hc1.currtemp is defined else 0}}",
  "min_temp": "5",
  "max_temp": "30",
  "temp_step": "0.5",
  "mode_cmd_t": "~/thermostat/hc1/mode",
  "modes": [
    "auto",
    "heat",
    "off"
  ],
  "dev": {
    "ids": [
      "ems-esp-thermostat"
    ],
    "name": "ems-esp-thermostat"
  },
  "avty": [
    {
      "t": "ems-esp/status",
      "val_tpl": "{{'online' if value == 'online' else 'offline'}}"
    },
    {
      "t": "~/thermostat_data",
      "val_tpl": "{{'online' if value_json.hc1 is defined and value_json.hc1.seltemp is defined else 'offline'}}"
    },
    {
      "t": "~/thermostat_data",
      "val_tpl": "{{'online' if value_json.hc1 is defined and value_json.hc1.currtemp is defined else 'offline'}}"
    },
    {
      "t": "~/thermostat_data",
      "val_tpl": "{{'offline' if value_json.hc1 is undefined or value_json.hc1.mode is undefined else 'online'}}"
    }
  ],
  "avty_mode": "all"
}

Bingo2023 · 2023-12-22T19:11:27Z

HA mode control fix see here:
Bingo2023@4c51b90

MichaelDvP · 2023-12-23T07:49:32Z

Thanks, i have never realized that mqtt enums are translated. Should they?
To make it work with all thermostats in all langauges, please check if this works too:

    snprintf(mode_str_tpl,
             sizeof(mode_str_tpl),
             "{%%if %s%%}off{%%elif %s=='%s'%%}heat{%%elif %s=='%s'%%}heat{%%elif %s=='%s'%%}off{%%elif %s=='%s'%%}off{%%else%%}auto{%%endif%%}",
             hc_mode_cond,
             hc_mode_s,
             Helpers::translated_word(FL_(manual)),
             hc_mode_s,
             Helpers::translated_word(FL_(day)),
             hc_mode_s,
             Helpers::translated_word(FL_(night)),
             hc_mode_s,
             Helpers::translated_word(FL_(off)));

Bingo2023 · 2023-12-23T09:07:31Z

I think it is monitoring the topic "ems-esp/thermostat_data".
I you check that message it is translated, see below:

In general it would be better not to translate mqtt twice, but at the moment large parts are already translated.
If we are don't translate "ems-esp/thermostat_data" it could solve the problem and we don't have to apply above mentioned fix.
On the other hand I don't know the side effect of removing the translation.

MichaelDvP · 2023-12-23T11:04:40Z

I've checked the code for HA discovery, the translation is right and usefull. The config uses the translated fullname and the translated enum-options as list. Sorry for confusiong, but i'm not using HA and it's sometimes difficult to understand.

So the change i've mentioned here #1398 (comment) should work. Please try.

Bingo2023 · 2023-12-23T13:19:39Z

Thanks, i have never realized that mqtt enums are translated. Should they? To make it work with all thermostats in all langauges, please check if this works too:

    snprintf(mode_str_tpl,
             sizeof(mode_str_tpl),
             "{%%if %s%%}off{%%elif %s=='%s'%%}heat{%%elif %s=='%s'%%}heat{%%elif %s=='%s'%%}off{%%elif %s=='%s'%%}off{%%else%%}auto{%%endif%%}",
             hc_mode_cond,
             hc_mode_s,
             Helpers::translated_word(FL_(manual)),
             hc_mode_s,
             Helpers::translated_word(FL_(day)),
             hc_mode_s,
             Helpers::translated_word(FL_(night)),
             hc_mode_s,
             Helpers::translated_word(FL_(off)));

it is working. I did an Commit out of Visual Studio Code, don't know if this helps - it is my first commit :)

MichaelDvP · 2023-12-23T13:25:38Z

I did an Commit out of Visual Studio Code, don't know if this helps - it is my first commit :)

Do you like to try a PR too?

Bingo2023 · 2023-12-23T14:36:52Z

done.

proddy · 2023-12-29T09:10:57Z

done, also merged into dev. Congrats on the PR @Bingo2023 !

MichaelDvP mentioned this issue Nov 12, 2023

Unable to set hc1_mode on BC400/GB172i.2 combo #1414

Closed

This was referenced Nov 20, 2023

hc1 mode off when set to manual #1440

Closed

Write Access to Thermostat RC310 does not work any more in latest Versions #1450

Closed

MichaelDvP mentioned this issue Dec 6, 2023

Thermostat HC1: can not set mode to OFF #1486

Closed

proddy added this to the v3.6.5 milestone Dec 29, 2023

proddy added the enhancement New feature or request label Dec 29, 2023

proddy closed this as completed Dec 29, 2023

Bingo2023 mentioned this issue Aug 11, 2024

HA dhw control is not working since 3.7.0-dev.30 [BC400] #1932

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend "HK1 Mode" #1398

Extend "HK1 Mode" #1398

Bingo2023 commented Nov 7, 2023

Bingo2023 commented Nov 7, 2023

MichaelDvP commented Nov 8, 2023

Bingo2023 commented Nov 9, 2023 •

edited

Loading

Bingo2023 commented Nov 22, 2023

t785634 commented Nov 22, 2023

Bingo2023 commented Nov 22, 2023

Bingo2023 commented Nov 22, 2023

t785634 commented Nov 22, 2023

proddy commented Dec 2, 2023

MichaelDvP commented Dec 2, 2023

Bingo2023 commented Dec 2, 2023 •

edited

Loading

t785634 commented Dec 4, 2023

proddy commented Dec 4, 2023

t785634 commented Dec 4, 2023 •

edited

Loading

Bingo2023 commented Dec 22, 2023

MichaelDvP commented Dec 23, 2023

Bingo2023 commented Dec 23, 2023 •

edited

Loading

MichaelDvP commented Dec 23, 2023

Bingo2023 commented Dec 23, 2023

MichaelDvP commented Dec 23, 2023

Bingo2023 commented Dec 23, 2023

proddy commented Dec 29, 2023

Extend "HK1 Mode" #1398

Extend "HK1 Mode" #1398

Comments

Bingo2023 commented Nov 7, 2023

Bingo2023 commented Nov 7, 2023

MichaelDvP commented Nov 8, 2023

Bingo2023 commented Nov 9, 2023 • edited Loading

Bingo2023 commented Nov 22, 2023

t785634 commented Nov 22, 2023

Bingo2023 commented Nov 22, 2023

Bingo2023 commented Nov 22, 2023

t785634 commented Nov 22, 2023

proddy commented Dec 2, 2023

MichaelDvP commented Dec 2, 2023

Bingo2023 commented Dec 2, 2023 • edited Loading

t785634 commented Dec 4, 2023

proddy commented Dec 4, 2023

t785634 commented Dec 4, 2023 • edited Loading

Bingo2023 commented Dec 22, 2023

MichaelDvP commented Dec 23, 2023

Bingo2023 commented Dec 23, 2023 • edited Loading

MichaelDvP commented Dec 23, 2023

Bingo2023 commented Dec 23, 2023

MichaelDvP commented Dec 23, 2023

Bingo2023 commented Dec 23, 2023

proddy commented Dec 29, 2023

Bingo2023 commented Nov 9, 2023 •

edited

Loading

Bingo2023 commented Dec 2, 2023 •

edited

Loading

t785634 commented Dec 4, 2023 •

edited

Loading

Bingo2023 commented Dec 23, 2023 •

edited

Loading