Skip to content
This repository has been archived by the owner on Feb 17, 2022. It is now read-only.

Fix alt key being a nav key #133

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Fix alt key being a nav key #133

merged 1 commit into from
Dec 9, 2020

Conversation

feliwir
Copy link
Contributor

@feliwir feliwir commented Nov 24, 2020

Fixes issue mentioned in #132
See @Daft-Freak

@feliwir
Copy link
Contributor Author

feliwir commented Nov 30, 2020

Can this please get merged anytime soon? @kripken

@kripken kripken requested a review from Daft-Freak November 30, 2020 20:47
@kripken
Copy link
Member

kripken commented Nov 30, 2020

@Daft-Freak is the best person to review this - I don't know the code that much.

If @Daft-Freak is not available, we can probably figure this out together, though, with some new tests and such.

@Daft-Freak
Copy link
Member

I think this should be okay. It's reverting a part of 993758c, but Alt+[key] wasn't a part of the issue that was fixing and I was wrong about it not generating any keypress events. I only have the usual nitpick-y comment of "prefix the commit message with emscripten:".

(I've got another key event patch I still haven't got around to testing 65c1316)

@feliwir
Copy link
Contributor Author

feliwir commented Dec 8, 2020

@Daft-Freak i changed the commit message accordingly

@Daft-Freak Daft-Freak merged commit 2695e11 into emscripten-ports:master Dec 9, 2020
@Daft-Freak
Copy link
Member

Okay, merging and hoping it doesn't break some other usecase I'm unaware of. (Turns out this is hard to get right!)

Anyway, thanks!

@Daft-Freak Daft-Freak mentioned this pull request Mar 31, 2021
Merged
kripken added a commit to emscripten-core/emscripten that referenced this pull request Mar 31, 2021
@kripken
Update SDL2 to version_23 (#13800)
ef9703d 
Fixes include:

emscripten-ports/SDL2#132 / emscripten-ports/SDL2#133
emscripten-ports/SDL2#82 / emscripten-ports/SDL2#136
@Daft-Freak Daft-Freak mentioned this pull request Nov 8, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Daft-Freak Daft-Freak Awaiting requested review from Daft-Freak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@feliwir @kripken @Daft-Freak