Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.0.0 #1510

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Release 4.0.0 #1510

wants to merge 1 commit into from

Conversation

emscripten-bot
Copy link
Collaborator

@emscripten-bot emscripten-bot added the release Used to tag release PRs label Jan 13, 2025
@emscripten-bot emscripten-bot requested a review from a team January 13, 2025 22:26
@emscripten-bot emscripten-bot enabled auto-merge (squash) January 13, 2025 22:26
sbc100
sbc100 requested changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops .. should be 4.0.0

sbc100
sbc100 reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with PR title updated.

@dschuff dschuff changed the title Release 3.1.75 Release 4.0.0 Jan 13, 2025
@dschuff
Copy link
Member

dschuff commented Jan 13, 2025

Updated the tile. I'll wait for the tests to land it though.

@dschuff
Copy link
Member

dschuff commented Jan 13, 2025

Hm, the failures on the test-bazel runners look like they might be some kind of real issue. Maybe @walkingeyerobot has an idea what's happening?

@emscripten-bot emscripten-bot changed the title Release 4.0.0 Release 3.1.75 Jan 13, 2025
@emscripten-bot emscripten-bot force-pushed the create-pull-request/patch branch from 03f3e2f to ae7ca15 Compare January 13, 2025 22:39
@emscripten-bot emscripten-bot requested a review from a team January 13, 2025 22:39
@sbc100
Copy link
Collaborator

sbc100 commented Jan 13, 2025

Actually it looks like the node version being used it too old so it doesn't support import.meta.dirname. This needs node 20 I believe.

@sbc100
Copy link
Collaborator

sbc100 commented Jan 13, 2025

Maybe try updating node_version in bazel/emscripten_deps.bzl.

I guess it would make sense to match the emsdk version: 20.18.0. Maybe add a comment to keep them in sync too.

@walkingeyerobot
Copy link
Collaborator

#1511

I suspect sbc is right and this will unblock here

@sbc100 sbc100 disabled auto-merge January 14, 2025 00:16
@sbc100
Copy link
Collaborator

sbc100 commented Jan 14, 2025

Rebasing should fix now. Is there some reason you revert the PR title?

@sbc100 sbc100 changed the title Release 3.1.75 Release 4.0.0 Jan 14, 2025
@dschuff
Copy link
Member

dschuff commented Jan 14, 2025

In fact I didn't revert the PR title. The bot force-pushed over my changes and reverted the PR title. I'm just going to run create_release.py manually and then close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
release Used to tag release PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emscripten-bot @dschuff @sbc100 @walkingeyerobot