Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github actions workflow to create a release PR #1437

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

dschuff
Copy link
Member

@dschuff dschuff commented Aug 22, 2024

The action runs the existing create_release.py script in a new mode created for github actions. Rather than using local git commands, it uses a public action for creating a PR in the repository. The action can be triggered from the website or via the CLI tool, for example

gh workflow run create-release.yml -R emscripten-core/emsdk -F lto-sha=abc123 -F nonlto-sha=234567

The action runs the existing create_release.py script in a new mode created
for github actions. Rather than using local git commands, it uses a public
action for creating a PR in the repository. The action can be triggered from the
website or via the CLI tool, for example

gh workflow run create-release.yml -R emscripten-core/emsdk -F lto-sha=abc123 -F nonlto-sha=234567
@dschuff
Copy link
Member Author

dschuff commented Aug 22, 2024

For now this is no different than just running create_release.py locally and manually creating a PR from the resulting git branch. But I hope to add more automation as a follow up.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

scripts/create_release.py Outdated Show resolved Hide resolved
.github/workflows/create-release.yml Outdated Show resolved Hide resolved
.github/workflows/create-release.yml Outdated Show resolved Hide resolved
@dschuff dschuff enabled auto-merge (squash) August 22, 2024 21:59
@dschuff dschuff merged commit f010ca9 into emscripten-core:main Aug 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants