Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bazel] add tarball as an optional output #1383

Merged
merged 1 commit into from
May 15, 2024
Merged

[bazel] add tarball as an optional output #1383

merged 1 commit into from
May 15, 2024

Conversation

walkingeyerobot
Copy link
Collaborator

Usage would be something like:

filegroup(
    name = "hello-world-tarball",
    srcs = [":hello-world-wasm"],
    output_group = "_wasm_tar",
)

Fixes #1382

@walkingeyerobot
[bazel] add tarball as an optional output
fc713e2 
Usage would be something like:
```
filegroup(
    name = "hello-world-tarball",
    srcs = [":hello-world-wasm"],
    output_group = "_wasm_tar",
)
```
@walkingeyerobot walkingeyerobot mentioned this pull request May 15, 2024
Closed
sbc100
sbc100 approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp lgtm

@walkingeyerobot walkingeyerobot merged commit 399e539 into emscripten-core:main May 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version of wasm_cc_binary that doesn't untar the result?
2 participants
@walkingeyerobot @sbc100