Prefer curl for downloading files over urllib
#1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
use_curl
branch
3 times, most recently
from
0407661 to
910aa0e
Compare
dschuff
reviewed
Mar 13, 2024
sbc100
force-pushed
the
use_curl
branch
2 times, most recently
from
d1306f0 to
f7138bb
Compare
Merged
dschuff
reviewed
Mar 14, 2024
dschuff
approved these changes
Mar 14, 2024
This was referenced Mar 14, 2024
sbc100
added a commit
that referenced
this pull request
May 28, 2024
Since we use curl now (#1355) this should no longer be needed.
sbc100
added a commit
that referenced
this pull request
May 28, 2024
Since we use curl now (#1355) this should no longer be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially important on macOS where
urllibcan fail to verify certificates.See https://stackoverflow.com/questions/40684543/how-to-make-python-use-ca-certificates-from-mac-os-truststore
Fixes: #1207, #85, #1356, #1357, #1358