Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update file extension used by create_release script #1285

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Update file extension used by create_release script #1285

merged 1 commit into from
Oct 10, 2023

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Oct 10, 2023

This should have been part of #1235

@sbc100
Copy link
Collaborator Author

sbc100 commented Oct 10, 2023

I used this patch when creating #1286 using the script

@sbc100
Copy link
Collaborator Author

sbc100 commented Oct 10, 2023

The binaryen build failure is unrelated so I'm going to land this TBR

@sbc100 sbc100 merged commit 8e82384 into main Oct 10, 2023
@sbc100 sbc100 deleted the fix_create_release branch October 10, 2023 01:54
@dschuff
Copy link
Member

dschuff commented Oct 10, 2023

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken Awaiting requested review from kripken

@brendandahl brendandahl Awaiting requested review from brendandahl

@dschuff dschuff Awaiting requested review from dschuff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @dschuff