3.1.45 #1269
Merged
3.1.45 #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschuff
force-pushed
the
version_3.1.45
branch
from
f390af4 to
b6ce248
Compare
sbc100
approved these changes
Aug 23, 2023
|
Looks like you need to update the llvm include path here: |
|
And here: emsdk/bazel/emscripten_toolchain/toolchain.bzl Line 1084 in 350c19a |
shlomif
pushed a commit
to shlomif/emsdk
that referenced
this pull request
Sep 29, 2023
Also update emscripten include dir to v18, and change 17 to wildcard in emscripten deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.