Update mac builders to use Circle's gen2 mac runner #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This runner is faster and more efficient. Also factor the mac configuration into an executor.
sbc100
approved these changes
May 31, 2023
|
Great! (Although performance of our mac bots are (I imagine) way less of an issue since we only run a tiny subset of "@Crossplatform" tests now, right?) |
|
Yes. Also this is emsdk rather than emscripten so it doesn't run a lot. But I just noticed that it was running pretty slow when shipping the last release. |
shlomif
pushed a commit
to shlomif/emsdk
that referenced
this pull request
Sep 29, 2023
…1222) This runner is faster and more efficient. Also factor the mac configuration into an executor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runner is faster and more efficient.
Also factor the mac configuration into an executor.