Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.25 #1130

Merged
merged 1 commit into from
Nov 8, 2022
Merged

3.1.25 #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions bazel/revisions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,13 @@
# DO NOT MODIFY

EMSCRIPTEN_TAGS = {
"3.1.25": struct(
hash = "ff6babb041d0f31575cc16d15ef82c6222ca99b8",
sha_linux = "c5ae6b4525845ea36bde89cbf4e1d03de87a2658862d76c6a53bbf8de7c67ff5",
sha_mac = "d2581aaa7207f0d9dd9949247f0706bda8561e805d67aec166ed4f3b39c3a3fa",
sha_mac_arm64 = "dbcb76036a09248c2a839872c27b87b6d4ccc81e57add4e2a6f5e560a2c530fc",
sha_win = "3a86d98d934456a74ed06388c1487d95a0d5a3f31777636453f22e61d57d7fb1",
Comment on lines +5 to +10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where would I look to verify that these are the correct hashes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hash is a revision in the emscripten-releases repo. the other shas are created by scripts/update_bazel_workspace.sh and AFAIK don't correspond to something trivially verifiable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(but there are tests for the bazel bits that run on circleCI if you look below. I assume they work but probably only Mitch knows for sure :) )

),
"3.1.24": struct(
hash = "54217a0950bb1dafe8808cc6207d378e323f9d74",
sha_linux = "20e8e5bd745e3ad69c03bb877091d2fbb0c7db1eab309de8f185e9821aea40f4",
Expand Down
4 changes: 3 additions & 1 deletion emscripten-releases-tags.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"aliases": {
"latest": "3.1.24",
"latest": "3.1.25",
"latest-sdk": "latest",
"latest-arm64-linux": "3.1.21",
"latest-64bit": "latest",
Expand All @@ -10,6 +10,8 @@
"latest-releases-upstream": "latest"
},
"releases": {
"3.1.25": "ff6babb041d0f31575cc16d15ef82c6222ca99b8",
"3.1.25-asserts": "6b19d6a8c30d7b83ba2193625fc12cce9ae0206b",
Comment on lines +13 to +14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more differences than I would expect in the emscripten-releases repo between these two hashes. Why do they get different versions of binaryen, llvm, etc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to compare DEPS.tagged-release from the LTO version against DEPS from the asserts version. Those are the ones that get used in each build style. Maybe it would make sense to just update DEPS when we update DEPS.tagged release, just for clarity.

"3.1.24": "54217a0950bb1dafe8808cc6207d378e323f9d74",
"3.1.24-asserts": "4c20c7393ca208c740c16a97dbf305ba52fea2bb",
"3.1.23": "bfd5e63a44ba4c8568cd8ac87c27b35e40732bf4",
Expand Down