Add missing binaries for bazel #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Aug 1, 2022
walkingeyerobot
approved these changes
Aug 1, 2022
auto-merge was automatically disabled
October 26, 2022 18:09
Head branch was pushed to by a user without write access
kon72
force-pushed
the
fix_bazel
branch
2 times, most recently
from
d72f598 to
0e341ef
Compare
|
Can this be rebased and merged? |
ghorn
reviewed
Feb 24, 2023
bazel/emscripten_deps.bzl
Outdated
| @@ -54,12 +54,17 @@ filegroup( | |||
| "bin/clang{bin_extension}", | |||
| "bin/llc{bin_extension}", | |||
| "bin/llvm-ar{bin_extension}", | |||
| "bin/llvm-dwarfdump{bin_extension}", | |||
| "bin/llvm-mc{bin_extension}", | |||
There was a problem hiding this comment.
I had to remove this line to get it to work on an apple silicon mac. The error was
ERROR: /Users/greg/dev/repo/BUILD.bazel:39:10: Linking app failed: missing input file '@emscripten_bin_mac_arm64//:bin/llvm-mc'
There was a problem hiding this comment.
I think that file was removed from the prebuilt binaries. It should not be needed by emscripten.
|
I removed @sbc100 |
sbc100
approved these changes
Feb 25, 2023
shlomif
pushed a commit
to shlomif/emsdk
that referenced
this pull request
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some files to linker filegroup so that Bazel can build successfully in certain scenarios.
-gsource-map)--embed-file)-sEVAL_CTORS=1)-sSPLIT_MODULE=1)-sWASM=0)