Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export all files as @emscripten_bin_{platform}//:all #1294

Closed
attilaolah opened this issue Oct 29, 2023 · 0 comments · Fixed by #1295
Closed

Export all files as @emscripten_bin_{platform}//:all #1294

attilaolah opened this issue Oct 29, 2023 · 0 comments · Fixed by #1295
Assignees

Comments

@attilaolah
Copy link
Contributor

attilaolah commented Oct 29, 2023

The BUILD_FILE_CONTENT_TEMPLATE in bazel/emscripten_deps.bzl currently currently exports a selection of files used by the CC toolchain that is configured here.

I'm facing a problem while creating Configure, Make & CMake toolchains using Emscripten via rules_foreign_cc, where I need access to other files from the @emscripten_bin_linux repository, namely emconfigure[.py], emmake[.py] and emcmake[.py]. My current approach is to patch this repo (@emsdk) to modify the BUILD_FILE_CONTENT_TEMPLATE to export these files too.

Would you be accepting a pull request that simply adds an :all target to @emscripten_bin_linux and friends, which could then be used by toolchain developers to access other files from the binary repo? That would make my life easier.

kripken pushed a commit that referenced this issue Oct 30, 2023
Having an :all target is the most future-proof way here.

Closes #1294.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants