Skip to content

Commit

Permalink
Add some logging after download is finished. NFC
Browse files Browse the repository at this point in the history
Also move some code outside of the `using` block.
  • Loading branch information
sbc100 committed Jun 21, 2024
1 parent ca7b40a commit be02fca
Showing 1 changed file with 19 additions and 16 deletions.
35 changes: 19 additions & 16 deletions emsdk.py
Original file line number Diff line number Diff line change
Expand Up @@ -682,20 +682,21 @@ def download_with_curl(url, file_name):

def download_with_urllib(url, file_name):
u = urlopen(url)
file_size = get_content_length(u)
if file_size > 0:
print("Downloading: %s from %s, %s Bytes" % (file_name, url, file_size))
else:
print("Downloading: %s from %s" % (file_name, url))

file_size_dl = 0
# Draw a progress bar 80 chars wide (in non-TTY mode)
progress_max = 80 - 4
progress_shown = 0
block_sz = 256 * 1024
if not TTY_OUTPUT:
print(' [', end='')

with open(file_name, 'wb') as f:
file_size = get_content_length(u)
if file_size > 0:
print("Downloading: %s from %s, %s Bytes" % (file_name, url, file_size))
else:
print("Downloading: %s from %s" % (file_name, url))

file_size_dl = 0
# Draw a progress bar 80 chars wide (in non-TTY mode)
progress_max = 80 - 4
progress_shown = 0
block_sz = 256 * 1024
if not TTY_OUTPUT:
print(' [', end='')
while True:
buffer = u.read(block_sz)
if not buffer:
Expand All @@ -713,9 +714,11 @@ def download_with_urllib(url, file_name):
print('-', end='')
sys.stdout.flush()
progress_shown += 1
if not TTY_OUTPUT:
print(']')
sys.stdout.flush()

debug_print('finished downloading (%d bytes)' % file_size_dl)
if not TTY_OUTPUT:
print(']')
sys.stdout.flush()


# On success, returns the filename on the disk pointing to the destination file that was produced
Expand Down

0 comments on commit be02fca

Please sign in to comment.