Skip to content

Commit

Permalink
Update node for bazel (#1511)
Browse files Browse the repository at this point in the history
hopefully this unblocks the release?
  • Loading branch information
walkingeyerobot authored Jan 13, 2025
1 parent ce1d281 commit 0e594bc
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
7 changes: 4 additions & 3 deletions bazel/deps.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ def deps():
sha256 = "5a00869efaeb308245f8132a671fe86524bdfc4f8bfd1976d26f862b316dc3c9",
urls = ["https://github.com/aspect-build/rules_js/releases/download/v1.42.0/rules_js-v1.42.0.tar.gz"],
)

# Transitive dependencies of aspect_rules_js. We explicitly pull them here instead of calling their
# provided function to avoid requiring a call to rules_js_dependencies in WORKSPACE.
maybe(
Expand All @@ -39,9 +40,9 @@ def deps():
maybe(
http_archive,
name = "rules_nodejs",
strip_prefix = "rules_nodejs-6.2.0",
sha256 = "87c6171c5be7b69538d4695d9ded29ae2626c5ed76a9adeedce37b63c73bef67",
urls = ["https://github.com/bazelbuild/rules_nodejs/releases/download/v6.2.0/rules_nodejs-v6.2.0.tar.gz"],
strip_prefix = "rules_nodejs-6.3.2",
sha256 = "158619723f1d8bd535dd6b93521f4e03cf24a5e107126d05685fbd9540ccad10",
urls = ["https://github.com/bazel-contrib/rules_nodejs/releases/download/v6.3.2/rules_nodejs-v6.3.2.tar.gz"],
)
http_archive(
name = "bazel_features",
Expand Down
4 changes: 2 additions & 2 deletions bazel/emscripten_deps.bzl
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")
load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")
load("@aspect_rules_js//npm:repositories.bzl", "npm_translate_lock")
load(":revisions.bzl", "EMSCRIPTEN_TAGS")

def _parse_version(v):
Expand Down Expand Up @@ -120,7 +120,7 @@ def emscripten_deps(emscripten_version = "latest"):
if "nodejs_toolchains" not in excludes:
# Node 16 is the first version that supports darwin_arm64
nodejs_register_toolchains(
node_version = "16.6.2",
node_version = "20.18.0",
)

if "emscripten_bin_linux" not in excludes:
Expand Down

0 comments on commit 0e594bc

Please sign in to comment.