Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build freetype with -Wno-misleading-indentation #9957

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Dec 4, 2019

This is new compiler warning in clang that was causing the build
to fail.

This is new compiler warning in clang that was causing the build
to fail.
@sbc100 sbc100 requested a review from dschuff December 4, 2019 22:29
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if this works, but I don't think emcc_args are sent to every library building command? We don't invoke emcc ourselves there, the config/make system does.

I'd guess we need to add this in the freetype configure, or add CFLAGS to it's configure command, something like that.

(But, maybe we did forward emcc_args to there and I forgot?)

@sbc100
Copy link
Collaborator Author

sbc100 commented Dec 4, 2019

lgtm if this works, but I don't think emcc_args are sent to every library building command? We don't invoke emcc ourselves there, the config/make system does.

These flags are sent to the library build (via CFLAGS I guess). this is why we include the emcc_flags in the name of the cached library, since we build a different version for each flag combination.

This is why its failing, because we include -Werror by default in the tests.

I'd guess we need to add this in the freetype configure, or add CFLAGS to it's configure command, something like that.

(But, maybe we did forward emcc_args to there and I forgot?)

@sbc100 sbc100 merged commit 2fcb0c0 into incoming Dec 5, 2019
@sbc100 sbc100 deleted the fix_freetype branch December 5, 2019 01:05
@sbc100 sbc100 mentioned this pull request Dec 9, 2019
belraquib pushed a commit to belraquib/emscripten that referenced this pull request Dec 23, 2020
This avoids the new clang warning causing and errror: -Wno-misleading-indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants