Simplify linker flag handling #9502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Sep 25, 2019
emcc.py
Outdated
| return False | ||
|
|
||
| def add_link_flag(i, f): | ||
| # Filter out libraries that musl includes in libc itself, or with we |
sbc100
force-pushed
the
delay_link_flag_processing
branch
from
e7a7418 to
4fb7402
Compare
The only reason this is separate is because libc is a bc file under fastcomp.
sbc100
force-pushed
the
delay_link_flag_processing
branch
from
f47c2a0 to
84cae5e
Compare
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
The only reason this is separate is because libc is a bc file under fastcomp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #9475. It seems that whitelist of acceptable
link flags is preferable to a black list.
Also delay linker flag processing until after
shared.reconfigure_cache()since thedefault libraries paths can be effected by user settings.