Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove COMPILER_ENGINE config option #9469

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Remove COMPILER_ENGINE config option #9469

merged 3 commits into from
Sep 20, 2019

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Sep 20, 2019 •
edited
Loading

We only support NODE_JS for running the internal compiler tools and
we have no plans to support any other JS engine for this purpose so
this extra config option was just adding noise.

Also:

  • remove legacy JS_ENGINE (singular) setting.
  • JS_ENGINES now defaults to [NODE_JS] if its not configured.
  • Remove some docs references to V8_ENGINE and SPIDERMONKEY_ENGINE since they not
    required and are purely for tests (i.e. should not be used by end
    users)

@sbc100
Remove COMPILER_ENGINE config option
42088e3 
We only support NODE_JS for running the internal compiler tools and
we have no plans to support any other JS engine for this purpose so
this extra config option was just adding noise.

Also:
- remove legacy JS_ENGINE (singular) setting.
- JS_ENGINES now defaults to [NODE_JS] if its not configured.
- Remove references to V8_ENGINE and SPIDERMONKEY_ENGINE since they not
  required and are purely for tests (i.e. should not be used by end
  users)
@sbc100
.
4a9b14a
@sbc100 sbc100 requested a review from kripken September 20, 2019 17:44
@sbc100 sbc100 merged commit c8a7f1c into incoming Sep 20, 2019
@sbc100 sbc100 deleted the compiler_engine branch September 20, 2019 22:06
sbc100 added a commit that referenced this pull request Sep 30, 2019
@sbc100
Add a default for JS_ENGINES
9cdeee7 
Since we are guaranteed that `NODE_JS` is part of the config (since
all users need this) we can set a sensible default for `JS_ENGINES`.

This default was supposed to be part of #9469, but a bug meant the code
was dead and it was removed in #9499.

`JS_ENGINES` is needed for any users that want to run test code.

Fix `gen_struct_info.py` to explicitly use NODE_JS since this is the
only engine we expect users to have installed and the only one we
officially support outside of test code.
@sbc100 sbc100 mentioned this pull request Sep 30, 2019
Merged
sbc100 added a commit that referenced this pull request Oct 8, 2019
@sbc100
Add a default for JS_ENGINES
09a8300 
Since we are guaranteed that `NODE_JS` is part of the config (since
all users need this) we can set a sensible default for `JS_ENGINES`.

This default was supposed to be part of #9469, but a bug meant the code
was dead and it was removed in #9499.

`JS_ENGINES` is needed for any users that want to run test code.

Fix `gen_struct_info.py` to explicitly use NODE_JS since this is the
only engine we expect users to have installed and the only one we
officially support outside of test code.
sbc100 added a commit that referenced this pull request Oct 8, 2019
@sbc100
Add a default for JS_ENGINES (#9542)
95b3afd 
Since we are guaranteed that `NODE_JS` is part of the config (since
all users need this) we can set a sensible default for `JS_ENGINES`.

This default was supposed to be part of #9469, but a bug meant the code
was dead and it was removed in #9499.

`JS_ENGINES` is needed for any users that want to run test code.
belraquib pushed a commit to belraquib/emscripten that referenced this pull request Dec 23, 2020
@sbc100 @belraquib
Remove COMPILER_ENGINE config option (emscripten-core#9469)
0ad6e38 
We only support NODE_JS for running the internal compiler tools and
we have no plans to support any other JS engine for this purpose so
this extra config option was just adding noise.

Also:
- remove legacy JS_ENGINE (singular) setting.
- JS_ENGINES now defaults to [NODE_JS] if its not configured.
- Remove references to V8_ENGINE and SPIDERMONKEY_ENGINE since they not
  required and are purely for tests (i.e. should not be used by end
  users)
belraquib pushed a commit to belraquib/emscripten that referenced this pull request Dec 23, 2020
@sbc100 @belraquib
Add a default for JS_ENGINES (emscripten-core#9542)
648786a 
Since we are guaranteed that `NODE_JS` is part of the config (since
all users need this) we can set a sensible default for `JS_ENGINES`.

This default was supposed to be part of emscripten-core#9469, but a bug meant the code
was dead and it was removed in emscripten-core#9499.

`JS_ENGINES` is needed for any users that want to run test code.
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 13, 2024
@sbc100
Remove JS_ENGINES and COMPILER_ENGINE from config file
593e7fd 
`COMPILER_ENGINE` was completely removed from emscripten in
emscripten-core/emscripten#9469.

`JS_ENGINES` is only used/needed for testing and is no longer needed
as of emscripten-core/emscripten#9542.
@sbc100 sbc100 mentioned this pull request Mar 13, 2024
Merged
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 13, 2024
@sbc100
Remove JS_ENGINES and COMPILER_ENGINE from config file
afc0b36 
`COMPILER_ENGINE` was completely removed from emscripten in
emscripten-core/emscripten#9469.

`JS_ENGINES` is only used/needed for testing and is no longer needed
as of emscripten-core/emscripten#9542.
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 13, 2024
@sbc100
Remove JS_ENGINES and COMPILER_ENGINE from config file
e68a0c2 
`COMPILER_ENGINE` was completely removed from emscripten in
emscripten-core/emscripten#9469.

`JS_ENGINES` is only used/needed for testing and is no longer needed
as of emscripten-core/emscripten#9542.
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 13, 2024
@sbc100
Remove JS_ENGINES and COMPILER_ENGINE from config file
60d1d75 
`COMPILER_ENGINE` was completely removed from emscripten in
emscripten-core/emscripten#9469.

`JS_ENGINES` is only used/needed for testing and is no longer needed
as of emscripten-core/emscripten#9542.
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 13, 2024
@sbc100
Remove JS_ENGINES and COMPILER_ENGINE from config file
d3c08df 
`COMPILER_ENGINE` was completely removed from emscripten in
emscripten-core/emscripten#9469.

`JS_ENGINES` is only used/needed for testing and is no longer needed
as of emscripten-core/emscripten#9542.
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 13, 2024
@sbc100
Remove JS_ENGINES and COMPILER_ENGINE from config file
97ffb86 
`COMPILER_ENGINE` was completely removed from emscripten in
emscripten-core/emscripten#9469.

`JS_ENGINES` is only used/needed for testing and is no longer needed
as of emscripten-core/emscripten#9542.
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 14, 2024
@sbc100
Remove JS_ENGINES and COMPILER_ENGINE from config file
6ffa04d 
`COMPILER_ENGINE` was completely removed from emscripten in
emscripten-core/emscripten#9469.

`JS_ENGINES` is only used/needed for testing and is no longer needed
as of emscripten-core/emscripten#9542.
sbc100 added a commit to emscripten-core/emsdk that referenced this pull request Mar 14, 2024
@sbc100
Remove JS_ENGINES and COMPILER_ENGINE from config file (#1354)
5726ccc 
`COMPILER_ENGINE` was completely removed from emscripten in
emscripten-core/emscripten#9469.

`JS_ENGINES` is only used/needed for testing and is no longer needed
as of emscripten-core/emscripten#9542.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbc100 @kripken