Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly free pthread TSD storage #9025

Merged
merged 2 commits into from
Jul 19, 2019
Merged

Correctly free pthread TSD storage #9025

merged 2 commits into from
Jul 19, 2019

Conversation

quantum5
Copy link
Member

The pointer is stored pthread.threadInfoStruct under the tsd field, and retrieved as local variable tlsMemory. However, pthread.tlsMemory is freed. Printing confirms that pthread.tlsMemory is undefined.

@quantum5 quantum5 requested review from kripken and juj July 18, 2019 23:58
kripken
kripken approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@VirtualTim VirtualTim mentioned this pull request Jul 19, 2019
Merged
@quantum5 quantum5 merged commit 6e87311 into emscripten-core:incoming Jul 19, 2019
belraquib pushed a commit to belraquib/emscripten that referenced this pull request Dec 23, 2020
@quantum5 @belraquib
Correctly free pthread TSD storage (emscripten-core#9025)
6e06e72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kripken kripken kripken approved these changes

@juj juj Awaiting requested review from juj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quantum5 @kripken