Asyncify: fix abort() handling #9000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"Asyncify wasm error handling leads to unreachables being thrown." Why? Could the Asyncify implementation call abort() instead, or is this intrinsic the way its implemented? |
|
I should have given more background, yeah. Asyncify is designed as a standalone binaryen pass - it knows nothing about emscripten. You can run it on arbitrary wasm. So it uses the universal We could add an "emscripten" mode to it, but I preferred to keep the emscripten-specific details here in emscripten. |
sbc100
approved these changes
Jul 16, 2019
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
Asyncify wasm error handling leads to unreachables being thrown. This PR maps those errors into calls to abort(), which ensures the runtime is properly shut down if they occur. In particular, no more code will be run, which could previously be confusing while debugging. Background: Asyncify is designed as a standalone binaryen pass - it knows nothing about emscripten. You can run it on arbitrary wasm. So it uses the universal unreachable error mechanism. (We could add an "emscripten" mode to it there, but I preferred to keep the emscripten-specific details here in emscripten.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asyncify wasm error handling leads to
unreachables being thrown. This PR maps those errors into calls toabort(), which ensures the runtime is properly shut down if they occur. In particular, no more code will be run, which could previously be confusing while debugging.