Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to SDL.estimateTextWidth same generic-font family as in TTF_RenderText_Solid #5329

Merged
merged 1 commit into from
Jul 11, 2017

Conversation

caiiiycuk
Copy link
Contributor

Realted to #5269, sorry It should been fixed in previous request.

@kripken
Copy link
Member

kripken commented Jun 22, 2017

How about adding a helper function that given a size and a name, returns h + 'px ' + fontData.name + ', serif'? Looks like we do that in two places, so might as well share the code.

@juj juj added the SDL label Jun 30, 2017
@caiiiycuk
Copy link
Contributor Author

Fixed :)

@kripken kripken merged commit ec59f6d into emscripten-core:incoming Jul 11, 2017
@kripken
Copy link
Member

kripken commented Jul 11, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants