gamepad_only_once_per_frame #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if subsequent polls might change the data under the hood, which might lead to missing button events if they are buffered. See w3c/gamepad#22. Also reduces the amount of garbage that is generated, and the number of times we jump to a call inside the browser if application iterates through multiple gamepads per frame.
…ate query to be extra precise.
|
lgtm |
satoshinm
added a commit
to satoshinm/emscripten
that referenced
this pull request
May 6, 2017
…-coreGH-4292 Joystick connected/disconnected callbacks are also now called in refreshJoysticks(). The gamepadconnected/disconnected events are only used as a hint to refresh the joysticks, whose getGamepads() state is compared to the previous state to determine the new state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only poll gamepad api once per application frame in order to be safe if subsequent polls might change the data under the hood, which might lead to missing button events if they are buffered. See w3c/gamepad#22. Also reduces the amount of garbage that is generated, and the number of times we jump to a call inside the browser if application iterates through multiple gamepads per frame.