Musl rand #2719
Merged
Musl rand #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mp version to 1.23.1 to have cached libc rebuilt with prng routines.
|
I did some testing and it seems that the lowest 3 or 4 bits might not be random. Can you write a testcase which tests %16 or something? This shows why using modulo for reducing the range is a Bad Idea and raises the question "how the hell did this work in the first place?" |
|
Ok, improved the test to run through all produced bits, not just the lowest one. It does pass on my system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to using musl functions for random number generation. Fixes issue #2341.