Preserve system library ordering even under EMCC_FORCE_STDLIBS=1 #22171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
force_stdlibs
branch
2 times, most recently
from
df67369 to
e10c580
Compare
|
Thank you so much 💙 , I tested the PR, and confirmed it fixes Godot nothreads+dlink builds. |
kripken
reviewed
Jul 1, 2024
kripken
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular
EMCC_FORCE_STDLIBS=1would previously place libc before libbulkmemory which don't work. libbulkmemory always needs to come first on the link line.Fixes: #22161